Fix ionide/ionide-vscode-fsharp#1906 #1152
Conversation
|
What is that build error about? |
|
Build and test / Build on windows-latest for repo global.json (pull_request) Failing after 26m |
|
Now it's |
| if not (Range.rangeContainsRange x.TotalRange m) then | ||
| // indexing into first line of empty file can be encountered when typing from an empty file | ||
| // if we don't check it, GetLineString will throw IndexOutOfRangeException | ||
| if (x :> ISourceText).GetLineCount() = 0 then |
There was a problem hiding this comment.
We should probably add an IsEmpty onto the IFSACSourceText interface.
There was a problem hiding this comment.
Is the use of this IsEmpty widespread enough to make a change to public API?
| let config = config |> AVal.force | ||
| do! builtInCompilerAnalyzers config volatileFile parseAndCheck | ||
| do! runAnalyzers config parseAndCheck volatileFile | ||
| if volatileFile.Source.Length = 0 then |
There was a problem hiding this comment.
Probably should try to not expose indices like this. Maybe use the IsEmpty suggestion above.
There was a problem hiding this comment.
What do you mean by indices? There is no index here. It's just a length test.
|
|
||
| else // When a user does "File -> New Text File -> Select a language -> F#" without saving, the file won't exist | ||
| return |
There was a problem hiding this comment.
Hmm this file should be added to the openFiles and shouldn't be getting here. Probably better to return None instead
There was a problem hiding this comment.
There will still be warnings written to VSCode output if I return None here. Returning this value, meanwhile, doesn't result in warnings written to VSCode output.
|
@TheAngryByrd No idea about that. I only verified with a new VSCode instance and typing from there. However, since tests test both NamedText and RoslynSourceText, and I only had to modify NamedText to make tests pass, I think RoslynSourceText works fine. |
|
Thanks you!! |
|
You're welcome!! |
* Fix #1906 * You gotta be trolling me * never seen fantomas used this way * More tests * Oops * clarify error * fix grammar
WHAT
🤖 Generated by Copilot at 8ff5882
This pull request improves the support for empty or unsaved files in the F# language server and the
NamedTexttype. It fixes potential exceptions, skips unnecessary operations, and adds tests for the language server features on empty files. It affects the filessrc/FsAutoComplete.Core/FileSystem.fs,src/FsAutoComplete/LspServers/AdaptiveFSharpLspServer.fs,test/FsAutoComplete.Tests.Lsp/EmptyFileTests.fs, andtest/FsAutoComplete.Tests.Lsp/Program.fs.🤖 Generated by Copilot at 8ff5882
🧪🛠️📄
WHY
Fixes ionide/ionide-vscode-fsharp#1906
HOW
🤖 Generated by Copilot at 8ff5882
NamedTexttype (link, link, link) and theAdaptiveFSharpLspServertype (link, link, link) by adding checks for the length of the source text and returning default or empty values as appropriate.